[PATCH] D13710: New X86 FMA3*_Int opcodes for scalar FMA intrinsics.

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 12:40:40 PST 2015


delena accepted this revision.
delena added a reviewer: delena.
delena added a comment.
This revision is now accepted and ready to land.

I don't have more questions. Thank you.
LGTM.


================
Comment at: llvm/test/CodeGen/X86/fma-intrinsics-phi-213-to-231.ll:171
@@ +170,3 @@
+; CHECK-NEXT: retq
+define <4 x float> @fmaddsubps_loop_128(i32 %iter, <4 x float> %a, <4 x float> %b, <4 x float> %c) {
+entry:
----------------
v_klochkov wrote:
> delena wrote:
> > The test checks that  FMA intrinsic gives the right form of FMA instruction.
> > I don't understand why do you need a loop here. We wrote a lot of FMA intrinsic tests without any loops.
> The loop is needed to get the right form of FMA instruction, i.e. the 231 form is generated when there is a LOOP DEPENDENCY on the ADD path. The test checks that 231 form is generated for such loops.
ok


http://reviews.llvm.org/D13710





More information about the llvm-commits mailing list