[PATCH] D14167: [lld][elf2] Generate PT_TLS.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 2 15:50:12 PST 2015
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
Comment at: ELF/Writer.cpp:674
@@ +673,3 @@
+ Elf_Phdr TlsPhdr;
+ TlsPhdr.p_vaddr = 0;
+ uintX_t ThreadBSSOffset = 0;
> ruiu wrote:
> > Do we need this? Isn't an Elf_Phdr zero-initialized?
> There's no explicit zero init, and I'm pretty sure default-initialization here does nothing.
I'd zero out all fields using memset.
More information about the llvm-commits