[PATCH] D14167: [lld][elf2] Generate PT_TLS.

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 15:30:33 PST 2015


Bigcheese added inline comments.

================
Comment at: ELF/Writer.cpp:671
@@ -678,1 +670,3 @@
+  Elf_Phdr *TlsPhdr = nullptr;
+  uintX_t ThreadBSSOffset = 0;
   // Create phdrs as we assign VAs and file offsets to all output sections.
----------------
ruiu wrote:
> ThreadBSSOffset -> TbssOffset since .tbss is a section name.
.tbss is not the only possible section name. And this variable exists because of that. It handles the case of multiple SHF_ALLOC | SHF_WRITE | SHF_TLS, SHT_NOBITS output sections.


http://reviews.llvm.org/D14167





More information about the llvm-commits mailing list