[PATCH] D8841: [X86][XOP] Add support for the matching of the VPCMOV bit select instruction

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 14:46:53 PST 2015


RKSimon added inline comments.

================
Comment at: test/CodeGen/X86/xop-pcmov.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx,+xop | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+xop | FileCheck %s
+
----------------
spatel wrote:
> Does the 'avx2' run exercise a different path through the code? If not, the plain 'avx' run should be sufficient by itself?
My reason for adding it was because the 256-bit integer AND/ANDN/OR ops are only legal on AVX2.


Repository:
  rL LLVM

http://reviews.llvm.org/D8841





More information about the llvm-commits mailing list