[PATCH] D14158: [StatepointLowering] Remove distinction between call and invoke safepoints

Igor Laevsky via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 10:23:49 PST 2015


igor-laevsky added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:349
@@ +348,3 @@
+
+    if (GCResult && GCResult->getParent() != CS.getParent()) {
+      // Result value will be used in different basic block so we need to export
----------------
reames wrote:
> Shouldn't it be an assert that GCResult is available if HasDef?  Actually, no.  But I think the gc.result in basic block case is going to be encountering the no use of result case.  Is that what you want?
Actually there is no difference on how to handle this case. I restructured code to make it more clear.


http://reviews.llvm.org/D14158





More information about the llvm-commits mailing list