[llvm] r251776 - [X86] Remove some llvm_unreachables after switches that already have an unreachable in their default case.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 1 23:24:30 PST 2015


Author: ctopper
Date: Mon Nov  2 01:24:30 2015
New Revision: 251776

URL: http://llvm.org/viewvc/llvm-project?rev=251776&view=rev
Log:
[X86] Remove some llvm_unreachables after switches that already have an unreachable in their default case.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=251776&r1=251775&r2=251776&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Nov  2 01:24:30 2015
@@ -3959,7 +3959,6 @@ static bool isX86CCUnsigned(unsigned X86
   case X86::COND_BE:    return true;
   case X86::COND_AE:    return true;
   }
-  llvm_unreachable("covered switch fell through?!");
 }
 
 /// Do a one-to-one translation of a ISD::CondCode to the X86-specific
@@ -12657,11 +12656,10 @@ SDValue X86TargetLowering::lowerUINT_TO_
     return lowerUINT_TO_FP_vXi32(Op, DAG, *Subtarget);
   case MVT::v16i8:
   case MVT::v16i16:
-    if (Subtarget->hasAVX512())
-      return DAG.getNode(ISD::UINT_TO_FP, dl, Op.getValueType(),
-                         DAG.getNode(ISD::ZERO_EXTEND, dl, MVT::v16i32, N0));
+    assert(Subtarget->hasAVX512());
+    return DAG.getNode(ISD::UINT_TO_FP, dl, Op.getValueType(),
+                       DAG.getNode(ISD::ZERO_EXTEND, dl, MVT::v16i32, N0));
   }
-  llvm_unreachable(nullptr);
 }
 
 SDValue X86TargetLowering::LowerUINT_TO_FP(SDValue Op,




More information about the llvm-commits mailing list