[PATCH] D13131: Allow the builting of the builtins library with a forced compiler.

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 06:10:07 PDT 2015


vkalintiris added inline comments.

================
Comment at: cmake/config-ix.cmake:110
@@ -106,9 +109,3 @@
 macro(test_target_arch arch def)
-  set(TARGET_${arch}_CFLAGS ${ARGN})
-  set(argstring "")
-  foreach(arg ${ARGN})
-    set(argstring "${argstring} ${arg}")
-  endforeach()
-  check_compile_definition("${def}" "${argstring}" HAS_${arch}_DEF)
-  if(NOT HAS_${arch}_DEF)
-    set(CAN_TARGET_${arch} FALSE)
+  if (CMAKE_C_COMPILER_FORCED AND NOT COMPILER_RT_BUILD_SANITIZERS AND
+      COMPILER_RT_DEFAULT_TARGET_ARCH STREQUAL "${arch}")
----------------
I placed the check here because we don't want to use the pre-configured TARGET_${arch}_CFLAGS. Additionally, I check that we don't build the sanitizers libraries because that would require a working C++ compiler.


http://reviews.llvm.org/D13131





More information about the llvm-commits mailing list