[PATCH] D14181: Update the discriminator assignment algorithm.

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 14:47:58 PDT 2015


dnovillo accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/Transforms/Utils/AddDiscriminators.cpp:219
@@ +218,3 @@
+                         << CurrentDIL->getColumn() << ":"
+                         << CurrentDIL->getDiscriminator() << *I1 << "\n");
+          }
----------------
Thanks. Could you please add this to the patch description and to the test case?  In the test case, it will help a lot if we have a description of what discriminators we are expecting in the source code itself.

Thanks for the fix!


http://reviews.llvm.org/D14181





More information about the llvm-commits mailing list