[PATCH] D14171: [ELF2] merge-string.s test fixed for win32 configuraton.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 07:33:52 PDT 2015


grimar added a comment.

In http://reviews.llvm.org/D14171#277782, @ruiu wrote:

> I don't think that's the design flaw of StringTableBuilder. StringTableBuilder creates a string table in memory, so naturally it cannot create a table that's larger than the virtual memory space. Thus size_t is the appropriate type.


Ok, I really dont want argue here and will make that change. Just remember how not long time ago Bill Gates also was sure that 640kb is enough for everyone. Thus one day that  change probably will be required anyways.


http://reviews.llvm.org/D14171





More information about the llvm-commits mailing list