[PATCH] D13481: [X86] Call locally defined function directly for PIE

H.J Lu via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 06:24:51 PDT 2015


hjl.tools updated this revision to Diff 38729.
hjl.tools added a comment.

I added a helper function, ClassifyGlobalFunctionReference, and used
it in both places.   I was looking for a predicate to tell me if a symbol is
defined.  The symbol can be weak or linkonce.  Should I use
!isDeclarationForLinker instead?


Repository:
  rL LLVM

http://reviews.llvm.org/D13481

Files:
  lib/Target/X86/X86FastISel.cpp
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86Subtarget.cpp
  lib/Target/X86/X86Subtarget.h
  test/CodeGen/X86/pie.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13481.38729.patch
Type: text/x-patch
Size: 7213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151029/ff38471b/attachment.bin>


More information about the llvm-commits mailing list