[PATCH] D14140: [ELF2] SECTIONS command basic support

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Config.h:38
@@ +37,3 @@
+};
+
+struct OutputSectionDescription {
----------------
May be regroup would look better ?


  llvm::StringRef InputFile;
  std::vector<llvm::StringRef> Names;
  std::vector<llvm::StringRef> ExcludeFiles;

================
Comment at: ELF/Writer.cpp:460
@@ +459,3 @@
+}
+
+template <class ELFT>
----------------
What about next one ?

```
 if (!IS || !IS->isLive() || IS == &InputSection<ELFT>::Discarded)
    return true;

return hasCustomSections() && InputToOutputSection.lookup(IS->getSectionName()) == "/DISCARD/";
```

================
Comment at: ELF/Writer.cpp:910
@@ +909,3 @@
+        InputToOutputSection[Name] = OutSec.second.Name;
+}
+
----------------
I think you want to use & after autos:
auto &OutSec, auto &InSec ...


http://reviews.llvm.org/D14140