[PATCH] D14097: PruneEH pass incorrectly reports that a change was made

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 21:20:25 PDT 2015


reames requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: lib/Transforms/IPO/PruneEH.cpp:158
@@ -157,3 +157,3 @@
 
       if (!SCCMightUnwind)
         NewAttributes.addAttribute(Attribute::NoUnwind);
----------------
I think it would be much clearer to restructure this code as:
if (!SCCMightUnwind &&
   !F->hasFnAttribute(Attribute::NoUnwind)) {
  F->addFnAttr(Attribute::NoUnwind);
  MadeChange = true;
}
...


http://reviews.llvm.org/D14097





More information about the llvm-commits mailing list