[PATCH] D13595: [SCEV][LV] Add SCEV Predicates and use them to re-implement stride versioning

[silviu.baranga@arm.com via llvm-commits]

sbaranga added a comment.

Hi Hal,

In http://reviews.llvm.org/D13595#277106, @hfinkel wrote:

> Why is all of the SCEVPredicate code in ScalarEvolution.{cpp.h}, as opposed to being in its own files? Is there a two-way coupling that I'm missing, or will there be one in the future?


Currently we use the memory pool from ScalarEvolution for the allocation of Predicates.

In the future I plan to make ScalarEvolution give some answers for getBackedgeCount which will be guarded by SCEVPredicates, so there will probably a tight coupling there.

Also, there's also a lot of commonality between the SCEV rewritting use cases and some of the reasoning that SCEV does already (at least that's what I observed for overflows and sext/zext handling). So there might be some opportunity for sharing code in these cases.

Thanks,
Silviu


http://reviews.llvm.org/D13595