[PATCH] D14148: [GlobalOpt] Demote globals to locals more aggressively

[James Molloy via llvm-commits]

jmolloy created this revision.
jmolloy added reviewers: dexonsmith, chandlerc, majnemer.
jmolloy added a subscriber: llvm-commits.
jmolloy set the repository for this revision to rL LLVM.

Global to local demotion can speed up programs that use globals a lot. It is particularly useful with LTO, when the entire call graph is known and most functions have been internalized.

For a global to be demoted, it must only be accessed by one function and that function:
  1. Must never recurse directly or indirectly, else the GV would be clobbered.
  2. Must never rely on the value in GV at the start of the function (apart from the initializer).

GlobalOpt can already do this, but it is hamstrung and only ever tries to demote globals inside "main", because C++ gives extra guarantees about how main is called - once and only once.

In LTO mode, we can often prove the first property (if the function is internal by this point, we know enough about the callgraph to determine if it could possibly recurse).

The second property can be proven for a subset of functions by proving that all loads from GV are dominated by a store to GV. This is conservative in the name of compile time - this only requires a DominatorTree which is fairly cheap in the grand scheme of things. We could do more fancy stuff with MemoryDependenceAnalysis too to catch more cases but this appears to catch most of the useful ones in my testing.

Some of the churn in this patch is due to reordering the optimizations that get done on globals. We were trying to demote first, and if that failed we were trying to delete the global. Now that we can demote on more occasions, actually demotion isn't as powerful as deletion so we need to swap these around to keep tests passing and not pessimize code.

Repository:
  rL LLVM

http://reviews.llvm.org/D14148

Files:
  lib/Transforms/IPO/GlobalOpt.cpp
  test/Transforms/GlobalOpt/2009-11-16-MallocSingleStoreToGlobalVar.ll
  test/Transforms/GlobalOpt/global-demotion.ll
  test/Transforms/GlobalOpt/metadata.ll
  test/Transforms/GlobalOpt/unnamed-addr.ll
  test/Transforms/MergeFunc/crash2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14148.38658.patch
Type: text/x-patch
Size: 14263 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151028/9687c165/attachment.bin>