[PATCH] D14143: [3/4] Allow SP in rGPR, starting from ARMv8 (disassembly)

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 04:09:16 PDT 2015


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!


================
Comment at: test/MC/Disassembler/ARM/invalid-thumbv7.txt:363
@@ -361,3 +362,3 @@
 
-[0xa1,0xe8,0x07,0x04]
+[0xa1 0xe8 0x07 0x04]
 # CHECK: warning: potentially undefined instruction encoding
----------------
tyomitch wrote:
> rengolin wrote:
> > Out of curiosity, what changes from commas to spaces here?
> Just for consistency with all other test cases in this file.
Ok, makes sense.


http://reviews.llvm.org/D14143





More information about the llvm-commits mailing list