[PATCH] D14143: [3/4] Allow SP in rGPR, starting from ARMv8 (disassembly)

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: test/MC/Disassembler/ARM/invalid-thumbv7.txt:363
@@ -361,3 +362,3 @@
 
-[0xa1,0xe8,0x07,0x04]
+[0xa1 0xe8 0x07 0x04]
 # CHECK: warning: potentially undefined instruction encoding
----------------
Out of curiosity, what changes from commas to spaces here?

================
Comment at: test/MC/Disassembler/ARM/thumb-v8.txt:2
@@ -2,1 +1,3 @@
+# RUN: llvm-mc -disassemble -triple thumbv8 -mattr=+db -show-encoding 2>%t < %s | FileCheck %s
+# RUN: FileCheck -allow-empty -check-prefix=STDERR < %t %s
 
----------------
Nice trick! :)


http://reviews.llvm.org/D14143