[PATCH] D13729: [TSAN, PowerPC] Setjmp/longjmp handling for PowerPC

[Dmitry Vyukov via llvm-commits]

dvyukov added a comment.

I did not look at the assembly because I don't understand it. But I am fine with it as long as tests pass. This code does not change frequently.


================
Comment at: lib/tsan/rtl/ppc-regs.h:1
@@ +1,2 @@
+#define r0 0
+#define r1 1
----------------
all tsan source file names currently start with tsan_, please keep this convention

================
Comment at: test/tsan/race_on_mutex.c:36
@@ -35,3 +35,3 @@
 // CHECK:      WARNING: ThreadSanitizer: data race
-// CHECK-NEXT:   Atomic read of size 1 at {{.*}} by thread T2:
+// CHECK-NEXT:   Atomic read of size {{.*}} at {{.*}} by thread T2:
 // CHECK-NEXT:     #0 pthread_mutex_lock
----------------
How does it happen that the access is not 1 byte?
This memory access is emulated in __tsan::MutexLock, and it explicitly coded as 1-byte.

This test change is unrelated to setjmp/longjmp and should go into a separate patch.


Repository:
  rL LLVM

http://reviews.llvm.org/D13729