[PATCH] D14122: [SimplifyCFG] Trim duplicate basic blocks in switch cases

Dylan McKay via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 19:26:49 PDT 2015


dylanmckay added inline comments.

================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:3462
@@ -3418,3 +3461,3 @@
   BasicBlock::iterator I = Succ->begin();
   while (PHINode *PHI = dyn_cast<PHINode>(I++)) {
     int Idx = PHI->getBasicBlockIndex(BB);
----------------
Does it really have a new incoming block? The block that contains the switch statement will still be the successor because all case statements are apart of the same basic block?

It is highly likely that I am misunderstanding, however.


http://reviews.llvm.org/D14122





More information about the llvm-commits mailing list