[PATCH] D14071: [FPEnv Core 06/14] Do not fold constants on reading in IR asm/bitcode

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 11:03:13 PDT 2015


majnemer added a comment.

In http://reviews.llvm.org/D14071#276298, @sdmitrouk wrote:

> In http://reviews.llvm.org/D14071#275275, @majnemer wrote:
>
> > That sounds like an oversight.  We have overflow flags (`nsw`/`nuw`) for integer math.
>
>
> Actually I asked about this last year, but it appeared that there is not much use of fast-math flags for constant expressions.
>  See it on the list <http://lists.llvm.org/pipermail/llvm-dev/2014-December/079242.html>.


I believe those concerns are primarily aimed at fast math flags which disable optimizations.  On your other patch, I commented that we should rephrase the two flags you proposed as enabling, rather than disabling, optimizations.


Repository:
  rL LLVM

http://reviews.llvm.org/D14071





More information about the llvm-commits mailing list