Re: [PATCH] D12399: Microsoft compatibility – add support for “relaxation” of memory operands in inline assembly.

[Tim Northover via llvm-commits]

t.p.northover added inline comments.

================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:2670-2672
@@ +2669,5 @@
+  uint64_t ErrorInfoIgnore;
+  // We are doing relaxcation only for microsoft OS.
+  // This will work only with triple -x86-64-pc-windows-msvc
+  bool RelaxcationMode = STI.getTargetTriple().getOS() == STI.getTargetTriple().Win32; 
+  unsigned M = MatchInstructionImpl(Operands, MInst, ErrorInfoIgnore,
----------------
majnemer wrote:
> Would it make more sense to predicate this on whether or not we are doing inline assembly instead of whether or not our OS is Windows?
I'm still keen to limit it to Windows somehow. I don't think people writing Intel inline assembly elsewhere will want wrong access size to be silently ignored: either of the contradictory specifiers could be the one intended.


http://reviews.llvm.org/D12399