[PATCH] D13595: [SCEV][LV] Add SCEV Predicates and use them to re-implement stride versioning

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 05:53:07 PDT 2015


sbaranga added inline comments.

================
Comment at: lib/Analysis/ScalarEvolution.cpp:9392
@@ +9391,3 @@
+  // Unique this node based on the arguments
+  ID.AddInteger(SCEVPredicate::P_Equal);
+  ID.AddPointer(LHS);
----------------
I've removed the versioning interface that was causing us to use this function (I should have probably done so the when you've previously asked for it).

We're now returning a Value*, so no need to use this getFirstInst function (which was removed). This removes a whole bunch of other problems (we aren't casting Value * to Instruction * anymore), so it should be much nicer.


http://reviews.llvm.org/D13595





More information about the llvm-commits mailing list