[PATCH] D14094: Add multikey_qsort to STLExtras.h

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 15:33:06 PDT 2015


ruiu updated this revision to Diff 38471.
ruiu added a comment.

Rewrite it with for(;;) to remove goto. (I was taught to think that a tail call is a jump as opposed to a call, so it was natural for me to use goto instead of for(;;) here, but I'm totally OK with for(;;) if this is more readable for others.)


http://reviews.llvm.org/D14094

Files:
  include/llvm/ADT/STLExtras.h
  lib/MC/StringTableBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14094.38471.patch
Type: text/x-patch
Size: 3958 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151026/2fbbb7ba/attachment.bin>


More information about the llvm-commits mailing list