[PATCH] D14095: Use Twin instead of std::to_string

Jonathan Roelofs via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 15:20:50 PDT 2015


jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.

LGTM with that change.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:3118
@@ -3118,2 +3117,3 @@
+        auto CurrentEpoch = Twine(bitc::BITCODE_CURRENT_EPOCH);
         return error(Twine("Incompatible epoch: Bitcode '") + BitcodeEpoch +
                      "' vs current: '" + CurrentEpoch + "'");
----------------
Drop the temporaries while you're at it:

    return error(Twine("Incompatible epoch: Bitcode '") + epoch +
                 "' vs current: '" + bitc::BITCODE_CURRENT_EPOCH + "'");


http://reviews.llvm.org/D14095





More information about the llvm-commits mailing list