[PATCH] D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825.

[Steve King via llvm-commits]

srking added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2332
@@ -2331,1 +2331,3 @@
   // sdiv, srem -> sdivrem
+  // Return DIVREM only if isIntDivCheap() is true.  Otherwise, we break the
+  // simplification logic in visitREM().
----------------
tyomitch wrote:
> I don't understand this comment. In particular, the code following the comment doesn't check for isIntDivCheap() before returning DIVREM. Is this intended as a FIXME: ?
This comment is a warning, not a FIXME.  This patch depends on the *current* way isIntDivCheap() checking happens in visitDIV() to  prevent visitDIV() from returning a DIVREM when the caller, visitREM() in this case, can't handle such transformation.  The nature and reason for this dependency is the brief text of the comment.


http://reviews.llvm.org/D14035