[PATCH] D13994: Optimization for pow(x, n) where n is some constant

[Chad Rosier via llvm-commits]

mcrosier added a comment.

Hi Mandeep,
The general rule of thumb for pinging a patch is about a week.  Also, David and others are likely busy getting prepared for the Dev Meeting later this week, so response may be delayed.

Also, I don't think you've properly addressed David's comment about the use of the isExactlyValue() function.  I could be mistaken, but I believe David is pointing out that there may be conversion error with some inputs.  The default value of 32 works, but will this work for all user specified values?

Personally, my suggestion would be to drop the command-line option all together.

Chad


http://reviews.llvm.org/D13994