[PATCH] D13481: [X86] Call locally defined function directly for PIE

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 25 18:08:05 PDT 2015


rafael added a subscriber: rafael.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3314
@@ -3313,1 +3313,3 @@
+          !(DAG.getTarget().Options.PositionIndependentExecutable &&
+            GV->isStrongDefinitionForLinker()) &&
           GV->hasDefaultVisibility() && !GV->hasLocalLinkage()) {
----------------
This needs to be refactored to a helper function that is used in both places.

Should this really be isStrongDefinitionForLinker? If this is a weak_odr or linkonce_odr, can't we avoid the plt? Add a test for that one way or the other.



Repository:
  rL LLVM

http://reviews.llvm.org/D13481





More information about the llvm-commits mailing list