[lld] r251173 - ELF2: Remove FIXMEs which we are not sure if we have to fix.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 18:46:40 PDT 2015


Author: ruiu
Date: Fri Oct 23 20:46:40 2015
New Revision: 251173

URL: http://llvm.org/viewvc/llvm-project?rev=251173&view=rev
Log:
ELF2: Remove FIXMEs which we are not sure if we have to fix.

Modified:
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=251173&r1=251172&r2=251173&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Fri Oct 23 20:46:40 2015
@@ -502,7 +502,6 @@ template <class ELFT> void Writer<ELFT>:
           if (S->isLive())
             scanRelocs(*S);
 
-  // FIXME: Try to avoid the extra walk over all global symbols.
   std::vector<DefinedCommon<ELFT> *> CommonSymbols;
   for (auto &P : Symtab.getSymbols()) {
     SymbolBody *Body = P.second->Body;
@@ -716,9 +715,6 @@ template <class ELFT> void Writer<ELFT>:
   auto &FirstObj = cast<ELFFileBase<ELFT>>(*Config->FirstElf);
   EHdr->e_ident[EI_OSABI] = FirstObj.getOSABI();
 
-  // FIXME: Generalize the segment construction similar to how we create
-  // output sections.
-
   EHdr->e_type = Config->Shared ? ET_DYN : ET_EXEC;
   EHdr->e_machine = FirstObj.getEMachine();
   EHdr->e_version = EV_CURRENT;




More information about the llvm-commits mailing list