[PATCH] D13818: [compiler-rt] [msan] Unify aarch64 mapping

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 15:33:02 PDT 2015


eugenis added a comment.

In general this looks very nice. I don't think we should be scared of the huge number of mappings, this is only a very minor constant work at startup. It also slows down MEM_IS_APP, of course, but it should not be noticeable provided that the loop in that function is fully unrolled - you might want to check that the assembly looks reasonable.


http://reviews.llvm.org/D13818





More information about the llvm-commits mailing list