[PATCH] D14024: [X86] Clean up the tail call eligibility logic

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2475
@@ +2474,3 @@
+static bool mayTailCallThisCC(CallingConv::ID CC) {
+  return isCCallConvention(CC) || canGuaranteeTCO(CC);
+}
----------------
hans wrote:
> ultra nit: I'd put these in the other order, so the guaranteed ones comes first, and the others read as an addition to those.
I like it this way, actually, because the default calling convention is the most common and the case most people care about. Also, we don't always guarantee that the other conventions always get TCO, we only guarantee it when CodeGenOptions tells us to.


http://reviews.llvm.org/D14024