[PATCH] D13996: Fix SLPVectorizer commutativity reordering

Michael Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 12:10:22 PDT 2015


mzolotukhin accepted this revision.
mzolotukhin added a comment.
This revision is now accepted and ready to land.

Hi Mehdi,

The change looks good to me provided a test would be added.

Thanks,
Michael


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2004
@@ -1991,4 +2003,3 @@
   }
-  // One opcode, put the instruction on the right.
-  if (ILeft) {
-    return true;
+  // Symetrically handle Left side.
+  if (AllSameOpcodeLeft) {
----------------
nitpick: Symmetrically with double 'm'?


http://reviews.llvm.org/D13996





More information about the llvm-commits mailing list