[llvm] r251135 - [RuntimeDyld][COFF] Fix a think-o in the handling of the IMAGE_REL_AMD64_ADDR64

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 11:46:43 PDT 2015


Author: lhames
Date: Fri Oct 23 13:46:43 2015
New Revision: 251135

URL: http://llvm.org/viewvc/llvm-project?rev=251135&view=rev
Log:
[RuntimeDyld][COFF] Fix a think-o in the handling of the IMAGE_REL_AMD64_ADDR64
relocation that was introduced in r250733.


Modified:
    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFX86_64.h
    llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s

Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFX86_64.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFX86_64.h?rev=251135&r1=251134&r2=251135&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFX86_64.h (original)
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFX86_64.h Fri Oct 23 13:46:43 2015
@@ -96,7 +96,7 @@ public:
     }
 
     case COFF::IMAGE_REL_AMD64_ADDR64: {
-      writeBytesUnaligned(0, Target, Value + RE.Addend);
+      writeBytesUnaligned(Value + RE.Addend, Target, 8);
       break;
     }
 

Modified: llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s?rev=251135&r1=251134&r2=251135&view=diff
==============================================================================
--- llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s (original)
+++ llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s Fri Oct 23 13:46:43 2015
@@ -28,6 +28,12 @@ inst1:
 .Ltmp2:
 	.seh_endproc
 
+        .data
+	.globl  x                       # @x
+# rtdyld-check: *{8}x = F
+x:
+	.quad	F
+
 # Make sure the JIT doesn't bail out on BSS sections.
         .bss
 bss_check:




More information about the llvm-commits mailing list