[PATCH] D13046: [mach-o] Support Windows line endings for -filelist parameter.

[Igor Kudrin via llvm-commits]

ikudrin added a comment.

In http://reviews.llvm.org/D13046#273717, @lhames wrote:

> Hi Igor,
>
> Apologies for not getting to this earlier. I meant that it should be
>  possible to add a filelist with carriage returns in it to reproduce the
>  failure.
>
> Are you still seeing the failure on the windows bots?
>
> Cheers,
>  Lang.


Hi Lang,

I didn't see the failure on any bots, I suppose they use svn to get the sources. I met the problem only on my Windows machine with git (on Windows, git usually converts line endings of text files during checkouts). But since then I've moved to Linux which doesn't have such a problem.

I think that if we add such a file as a test, it won't add any significant value, because the important property of the test (CR character at the end of line) will be //invisible// and the test could be changed unintentionally. Moreover, git will continue to treat this file as a text and can change line endings, depending on git's settings (we can avoid this situation by using .gitattributes file, but it makes things even more complicated, I think).

As a result, I can't imagine how to create a good test for this situation. May be the fact that this change doesn't broke anything is enough?


http://reviews.llvm.org/D13046