[PATCH] D13595: [SCEV][LV] Add SCEV Predicates and use them to re-implement stride versioning

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 09:12:40 PDT 2015


sbaranga marked 15 inline comments as done.

================
Comment at: lib/Analysis/ScalarEvolution.cpp:9478
@@ +9477,3 @@
+        Set->Preds.begin(), Set->Preds.end(),
+        [this](const SCEVPredicate *I) { return this->implies(I); });
+
----------------
I've tried using bind here but the code comes out horrible. For example:

 std::any_of(SCEVPreds.begin(), SCEVPreds.end(),
                    std::bind(&SCEVPredicate::implies, std::placeholders::_1, N));

This requires more characters to write and seems more difficult to read. Maybe we should skip using bind here?




http://reviews.llvm.org/D13595





More information about the llvm-commits mailing list