[PATCH] D13977: [X86] Add elfiamcu triple support, and a workaround for PR3997

David Kreitzer via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 09:04:19 PDT 2015


DavidKreitzer added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:27523
@@ +27522,3 @@
+  for (auto &Arg : Args) {
+    // For library functions, we do not expect any fancy types.
+    unsigned Size = DAG.getDataLayout().getTypeSizeInBits(Arg.Ty);
----------------
Is there an easy way to assert this, i.e. that there are no fancy types?  Also, you probably want to explicitly handle varargs functions here, either by asserting that you cannot get here for varargs functions or by excluding them from the inreg marking.



http://reviews.llvm.org/D13977





More information about the llvm-commits mailing list