[PATCH] D13945: [X86][AVX512] extend vcvtph2ps to support xmm/ymm and sae versions

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 01:55:37 PDT 2015


delena added inline comments.

================
Comment at: ../llvm/lib/Target/X86/X86InstrAVX512.td:5341
@@ +5340,3 @@
+  let Constraints = "$src0 = $dst",  AddedComplexity = 20 in
+    def rrk : AVX5128I<0x13, MRMSrcReg, (outs _dest.RC:$dst), 
+                      (ins _dest.RC:$src0, _dest.KRCWM:$mask, _src.RC:$src),
----------------
Please check if "maskable" can be used here.

================
Comment at: ../llvm/lib/Target/X86/X86InstrFragmentsSIMD.td:512
@@ +511,3 @@
+                              SDTypeProfile<1, 2, [SDTCisVec<0>, SDTCisVec<1>,
+                                                   SDTCVecEltisVT<0, f32>,
+                                                   SDTCisFP<0>, SDTCisInt<2>]> >;
----------------
Add description for elt VT of the source.


Repository:
  rL LLVM

http://reviews.llvm.org/D13945





More information about the llvm-commits mailing list