[PATCH] D13971: [ValueTracking] Expose `implies` via ValueTracking, NFC

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 00:54:39 PDT 2015


sanjoy added inline comments.

================
Comment at: lib/Analysis/ValueTracking.cpp:3944
@@ +3943,3 @@
+      APred == ICmpInst::ICMP_ULT &&
+      !CI->isNegative() &&
+      match(RHS, m_ICmp(BPred, m_Specific(I), m_Specific(L))) &&
----------------
majnemer wrote:
> Does this need to be here? `add nuw` can never decrease a number in unsigned-comparison space.
You're right, but I'm only moving the code, and I'd rather have this change not have any semantic effects.

I'll fix this up in a later commit.


http://reviews.llvm.org/D13971





More information about the llvm-commits mailing list