[PATCH] D13767: [X86] Fix more -Os + EH issues

Frederic Riss via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 20:52:49 PDT 2015

friss added a comment.

In http://reviews.llvm.org/D13767#272344, @rnk wrote:

> In http://reviews.llvm.org/D13767#272094, @mkuper wrote:
> > In particular, gnu_args_size is now only generated for fp-based CFA. Frederic, does that sounds right to you?
> Hm, I think there might be an issue here. The cfa_adjust directives don't instruct the unwinder to adjust ESP before transferring to the landingpad, right? They just help indicate where the return address lives in memory.

I think you are right, sorry for the confusion. What's the exact semantic of GNU_args_size? Is it only to be used when branching to a landing pad and ignored when just traversing the function?


More information about the llvm-commits mailing list