[PATCH] D13960: [ELF2] Symbol Versioning: part 1, VERSION() directive parsing

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 15:53:29 PDT 2015


ruiu added a comment.

Oh yeah, that's very unfortunate, but that's true.

I took a look at gold's source code and found that their lexer behaves differently depending on the context -- if it's outside of version script, ':' is a token character, but inside version script, only '::' are handled as part of a token. I don't know if we really want to have this craziness.

I'd really like to always handle ':' as a token character, and let users to update their linker script if not compatible with that behavior. Davide, could you grep all linker scripts in FreeBSD which has a space between 'global' or 'local' and the following semicolon and count that number?


http://reviews.llvm.org/D13960





More information about the llvm-commits mailing list