[PATCH] D13869: instruction 'align' in asm blocks works incorrectly with some cases of parameters

[Reid Kleckner via llvm-commits]

rnk added a comment.

In http://reviews.llvm.org/D13869#271894, @m_zuckerman wrote:

> We don't need to check this because we are under the rule of Microsoft. This function operate only when ParsingInlineAsm is true. This is true only in Microsoft inline asm.


Sure, ParsingInlineAsm is true, but there are actually multiple passes of assembly parsing. First we parse as intel style inline asm. This does rewrites as we go, to something that could be put in a .s file between .intel_syntax / .att_syntax directives. We take that result, reparse it using the regular asm parser, and then emit those MC instructions as either normal AT&T assembly or object code.

I claim you still need this rewrite on Darwin, which is not "under the rule of Microsoft" and alignment directives use log2 notation.


http://reviews.llvm.org/D13869