[PATCH] D13934: [ELF2] --strip-all/-s command line implemented

[Davide Italiano via llvm-commits]

davide added a comment.

Structure looks good, just few comments.


================
Comment at: ELF/Config.h:59
@@ -58,2 +58,3 @@
+  bool StripAll;
   bool Static = false;
   bool Verbose;
----------------
This is not sorted.

================
Comment at: ELF/Options.td:86
@@ +85,3 @@
+def strip_all : Flag<["--"], "strip-all">,
+  HelpText<"Omit all symbol information from the output file">;
+
----------------
Can't you just say "strip all symbols" as gold and ld do?

================
Comment at: test/elf2/strip-all.s:1
@@ +1,2 @@
+# Tests the --strip-all (-s) flag.
+# We expect that .symtab and .strtab are stripped from the final executable.
----------------
Please do not use obj2yaml, but use assembler for tests. This is the standard for the new ELF linker.


http://reviews.llvm.org/D13934