[PATCH] D13936: [CMake] Fix add_llvm_external_project()

[Chris Bieneman via llvm-commits]

LGTM. Thank you for fixing this.

-Chris

> On Oct 21, 2015, at 4:53 AM, Luchesar V. ILIEV <luchesar.iliev at gmail.com> wrote:
> 
> kerberizer created this revision.
> kerberizer added reviewers: beanz, chapuni, filcab, bogner, Bigcheese.
> kerberizer added a subscriber: llvm-commits.
> 
> r250835 unintentionally discarded the optional parameter to the add_llvm_external_project() macro that may point to a path when the said path is different from ${name}. This should fix it by passing ${ARGN} on to add_llvm_subdirectory(). The problem manifests itself with e.g. add_llvm_external_project(clang-tools-extra extra) from clang/tools/CMakeLists.txt
> 
> References:
> http://reviews.llvm.org/D13783
> http://llvm.org/viewvc/llvm-project?view=revision&revision=250835
> 
> http://reviews.llvm.org/D13936
> 
> Files:
>  cmake/modules/AddLLVM.cmake
> 
> Index: cmake/modules/AddLLVM.cmake
> ===================================================================
> --- cmake/modules/AddLLVM.cmake
> +++ cmake/modules/AddLLVM.cmake
> @@ -781,7 +781,7 @@
> # enable or disable building it with everything else.
> # Additional parameter can be specified as the name of directory.
> macro(add_llvm_external_project name)
> -  add_llvm_subdirectory(LLVM TOOL ${name})
> +  add_llvm_subdirectory(LLVM TOOL ${name} ${ARGN})
> endmacro()
> 
> macro(add_llvm_tool_subdirectory name)
> 
> 
> <D13936.37986.patch>