[PATCH] D13801: [Support] Extend sys::path with user_cache_directory function.

Paweł Bylica via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 03:07:49 PDT 2015


chfast marked 2 inline comments as done.

================
Comment at: lib/Support/Windows/Path.inc:775
@@ +774,3 @@
+bool user_cache_directory(SmallVectorImpl<char> &result) {
+  return getKnownFolderPath(FOLDERID_LocalAppData, result);
+}
----------------
It looks the best we can do is to repeat path::append interface that has optional path elements of type llvm::Twine. I don't think it is a good idea to do so. I've updated the doc comment of path::user_cache_directory and in my opinions it is enough. 


http://reviews.llvm.org/D13801





More information about the llvm-commits mailing list