[PATCH] D13869: instruction 'align' in asm blocks works incorrectly with some cases of parameters

[michael zuckerman via llvm-commits]

m_zuckerman marked an inline comment as done and an inline comment as not done.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:4678
@@ -4678,3 +4677,3 @@
 
     unsigned AdditionalSkip = 0;
     // Rewrite expressions in $N notation.
----------------
m_zuckerman wrote:
> rnk wrote:
> > rnk wrote:
> > > This is now always zero, so you should zap it.
> > Sorry, ignore this, I think we need to keep it along with the log2 machinery I asked you to remove.
> We can keep or not the log2 machinery it's Does not matter.  When we are here. we are under the rule of Microsoft. The rule of Microsoft is the value of the number. Numbers that have log2. Microsoft leaves this number as it is, and don't do anythink more.  
> Also the parseMSInlineAsm called only ones from Parser::ParseMicrosoftAsmStatement. This works when we under Microsft rule. So, the value is the inserted value. We don't need the extra AdditionalSkip. 
For now the only set is here and is 0 . Maybe in future it will be used.


http://reviews.llvm.org/D13869