[PATCH] D13910: [ELF2] Extract calculation of symbol binding as a separate function.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 13:10:46 PDT 2015


ruiu added a subscriber: ruiu.
ruiu accepted this revision.
ruiu added a reviewer: ruiu.
ruiu added a comment.

LGTM with a nit.


================
Comment at: ELF/OutputSections.cpp:822-823
@@ +821,4 @@
+template <class ELFT>
+unsigned char SymbolTableSection<ELFT>::getSymbolBinding(SymbolBody *Body) {
+  unsigned char Visibility = Body->getMostConstrainingVisibility();
+  if (Visibility != STV_DEFAULT && Visibility != STV_PROTECTED)
----------------
unsigned char -> uint8_t


http://reviews.llvm.org/D13910





More information about the llvm-commits mailing list