HA: [PATCH] D13904: [ELF2] .shstrtab section implemented

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 10:43:21 PDT 2015


>> Yes, some of them were changed after test, but some another probably is just cosmetics. Sorry I was read your mail after commiting already.
>> I did not think that is so important. I can revert and commit separately if needed, or leave as is.
>
>No need to revert I think, but unrelated changes make the patch less
>readable. Just a good practice to make our life easier if in 6 months
>we look at this again, not a mandatory requirement.

I see. 
Actually that indices breaks tests often. I would vote to forbide using of them in tests if test itself does not requires it.


More information about the llvm-commits mailing list