[lld] r250725 - Fix comment.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 23:59:20 PDT 2015


Not sure how much overhead this is causing for you LLD developers (then
again, issues may be lurking unnoticed), but we could maybe add
`CHECK-EXPRESSION` to FileCheck that evaluates the expression and verifies
it is true?

As a bonus we could use FileCheck's existing variable capture mechanism to
substitute in values directly. Seems like all that is needed is a
precedence parser/evaluator for `+` `-` `==`, parentheses, and hex/dec
literals, which should be pretty tiny.

On Mon, Oct 19, 2015 at 12:24 PM, Rafael Espindola via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: rafael
> Date: Mon Oct 19 14:24:03 2015
> New Revision: 250725
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250725&view=rev
> Log:
> Fix comment.
>
> Modified:
>     lld/trunk/test/elf2/comdat.s
>
> Modified: lld/trunk/test/elf2/comdat.s
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf2/comdat.s?rev=250725&r1=250724&r2=250725&view=diff
>
> ==============================================================================
> --- lld/trunk/test/elf2/comdat.s (original)
> +++ lld/trunk/test/elf2/comdat.s Mon Oct 19 14:24:03 2015
> @@ -20,7 +20,7 @@ foo:
>  // CHECK: Disassembly of section bar:
>  // CHECK-NEXT: bar:
>  // 0x1000 - 0x1001 - 5 = -6
> -// 0      - 0x1006 - 5 = -8203
> +// 0      - 0x1006 - 5 = -4107
>  // CHECK-NEXT:   1001: {{.*}}  callq  -6
>  // CHECK-NEXT:   1006: {{.*}}  callq  -4107
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151019/374599b6/attachment.html>


More information about the llvm-commits mailing list