[PATCH] D13856: [ELF2] - Lazy relocation support for x86_64.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 13:00:43 PDT 2015


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. Let's give it a shot. Please verify that you can still self-host with this patch on x86-64 before submitting.


================
Comment at: ELF/OutputSections.h:113
@@ +112,3 @@
+class GotPltSection final : public OutputSectionBase<ELFT> {
+  typedef OutputSectionBase<ELFT> Base;
+  typedef typename llvm::object::ELFFile<ELFT>::uintX_t uintX_t;
----------------
Now I think you can remove this line.

================
Comment at: ELF/Target.cpp:680
@@ -628,2 +679,3 @@
   // GotReloc = FIXME
+  // PltReloc = FIXME
   PageSize = 65536;
----------------
Did you?


http://reviews.llvm.org/D13856





More information about the llvm-commits mailing list