[PATCH] D13767: [X86] Fix more -Os + EH issues

Frederic Riss via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 12:52:36 PDT 2015


friss added inline comments.

================
Comment at: test/CodeGen/X86/push-cfi-obj.ll:27
@@ +26,3 @@
+; LINUX-NEXT:      0020: 1C000000 24000000 00000000 19000000  |....$...........|
+; LINUX-NEXT:      0030: 04000000 00430E10 2E100E20 500E1000  |.....C..... P...|
+; LINUX-NEXT:    )
----------------
I'm sorry I didn't look at the patch in more details, but does the above mean that you emit GNU_args_size and def_fa_offset in the same function? If that's the case, it seems wrong: if the offset is reflected by def_cfa_offsets, you don't need the GNU_args_size anymore. 


http://reviews.llvm.org/D13767





More information about the llvm-commits mailing list