[PATCH] D13818: [compiler-rt] [msan] Unify aarch64 mapping

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 11:58:46 PDT 2015


eugenis added inline comments.

================
Comment at: lib/msan/msan.h:89
@@ -70,3 +88,3 @@
 # define LINEARIZE_MEM(mem) \
   (((uptr)(mem) & ~0x7C00000000ULL) ^ 0x100000000ULL)
 # define MEM_TO_SHADOW(mem) (LINEARIZE_MEM((mem)) + 0x4000000000ULL)
----------------
This is probably out of scope of this review, but could your elaborate, and maybe add a comment, about the constraints that led to this complex mapping function? For example, a list of all address ranges that must be in "app" regions would help.

This mapping limits the applications to roughly 1/7th of the address space on 39 bit VMA and only 1/30th on 42 bit VMA. Could we do any better?



http://reviews.llvm.org/D13818





More information about the llvm-commits mailing list