[PATCH] D13791: In machine block placement, use 60% instead of 80% as the hot branch probability threshold when profile data is available.

[Cong Hou via llvm-commits]

congh added a comment.

Thanks for the review!

In http://reviews.llvm.org/D13791#268719, @bkramer wrote:

> We use 80% as the 'hot' probability in many places. Would it make sense to add a getHotProbability(bool HasProfileData) to BranchProb so we can remove the magic numbers here? No need to do that in this patch but maybe in a follow-up.
>
> Then we can check if the other users of 80% can also make smarter decisions when they know the probabilities come from prof data.


I am not sure if using the same "hot" probability in other places is a good idea as I am not sure how it is used there. After all, "hot" has different definitions depending on its context. But it is a good idea to at least try it.


http://reviews.llvm.org/D13791